roles/agent/windows: uri => win_uri #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable goes unused.
win_uri was introduced in ansible.windows collection v2.8.0
Only set zabbix_agent_version_long if not already defined. Allows for running the version of your own choosing, incase a downgrade is needed. Updating some documentation to reflect the change. Check suggested by @patrik-plastik.
pyrodie18
approved these changes
Sep 1, 2025
Collaborator
pyrodie18
left a comment
There was a problem hiding this comment.
I went ahead and approved but want to just toss some food for thought before you merge.
- Is this a breaking change? I could argue yes because we're pinning a version of Windows which we never have before. If I remember correctly, it came out in March so it is entirely possible users haven't downloaded it. But its also with the Windows part of the collection which we've always said was simply best effort.
- I'll be honest. I still don't totally understand what the issue creator is trying to do and why this run on the windows host vs the controller like it is supposed to which leads me to the question of does this fall within the 80% rule or does this fall into a edge case where they are better off forking and making what appears to be a very simple change.
FYI those comments are related to the one task and not the variable cleanup which I have zero issues with.
Collaborator
Author
Agreed.
Yeah, I don't quite know how this gets executed on the Windows host unless he commented out the
The variable name cleanup is probably more of a breaking change, as users might have put values under the previous names, but it's been broken a while so 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Swap out uri for win_uri and some minor cleanups related to the change.
zabbix_agent_version_longcheck suggested by @patrik-plastik in #1589Fixes #1621
Fixes #1627
ISSUE TYPE
COMPONENT NAME
roles/zabbix_agent
ADDITIONAL INFORMATION
Requires
ansible.windows: ">=2.8.0"