[PR #4145/9b0eca61 backport][stable-4.7] screenshot tests: add more screens, blackout time, enable legacy#4146
Merged
himdel merged 1 commit intoAug 27, 2023
Conversation
* screenshot tests: add more screens, blackout time, enable legacy No-Issue * lint * rename screenshots.js to screenshots-main when cached, fix paths for extra suite name (cherry picked from commit 9b0eca6)
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4145 as merged into master (9b0eca6).
Change screenshot folder from
cypress/screenshots/test_name.js/tocypress/screenshots/test_suite_name/test_name.js/(test_suite meaning all thecypress/e2e/subdirs used in test matrix).Wrap our
DateComponentin a<time>element, following https://microformats.org/wiki/datetime-design-pattern,blackout
timeelements in non-failure cypress screenshots - we can test more screens.Enable legacy roles for the screenshots run, allowing us to test those screens.