Skip to content

screenshot tests - fix Signature keys inconsistent order#4211

Merged
himdel merged 1 commit into
ansible:masterfrom
himdel:signature-screenshots
Sep 11, 2023
Merged

screenshot tests - fix Signature keys inconsistent order#4211
himdel merged 1 commit into
ansible:masterfrom
himdel:signature-screenshots

Conversation

@himdel

@himdel himdel commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

fix Signature keys inconsistent order and fingerprint changing..

default to sort by name (instead of undefined),
and blackout the fingerprint for the screenshot so we don't fail on differences there.

@himdel himdel added the tests tests PR label Sep 11, 2023
@github-actions github-actions Bot added the backport-4.7 This PR should be backported to stable-4.7 (2.4) label Sep 11, 2023
@himdel himdel merged commit 28376cc into ansible:master Sep 11, 2023
@himdel himdel deleted the signature-screenshots branch September 11, 2023 01:38
@patchback

patchback Bot commented Sep 11, 2023

Copy link
Copy Markdown

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/28376ccbfc8f94b0352af9b7ebdd7277967ad090/pr-4211

Backported as #4215

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Sep 11, 2023
and fingerprint changing

No-Issue

(cherry picked from commit 28376cc)
himdel added a commit that referenced this pull request Sep 11, 2023
and fingerprint changing

No-Issue

(cherry picked from commit 28376cc)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions Bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4) tests tests PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant