Skip to content

Fix logo size in collection list#3567

Merged
jerabekjiri merged 1 commit into
ansible:masterfrom
jerabekjiri:fix/collection-logo-size
Apr 13, 2023
Merged

Fix logo size in collection list#3567
jerabekjiri merged 1 commit into
ansible:masterfrom
jerabekjiri:fix/collection-logo-size

Conversation

@jerabekjiri

@jerabekjiri jerabekjiri commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

Issue: AAH-2272

before:
Screenshot from 2023-04-11 14-42-14

after:
Screenshot from 2023-04-11 14-10-02

@github-actions github-actions Bot added backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) labels Apr 11, 2023
@jerabekjiri jerabekjiri removed the backport-4.6 This PR should be backported to stable-4.6 (2.3) label Apr 11, 2023
@himdel

himdel commented Apr 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We still need to limit the size of the image somehow.

With this change, tall images break - you can try with http://placekitten.com/40/400 (/width/height)

Before:
20230411152307
After:
20230411152328

Would it make sense to just change that 40px to a value closer to what's actually available, but keep it there?

@himdel

himdel commented Apr 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

One more note... the default-logo image we're using is a 214x214 logo inside a 300x300 transparent image

So there's a chance that particular logo will always look too small until we crop it?

@jerabekjiri
unlock logo size
4e4d8dd 
Issue: AAH-2272
@jerabekjiri jerabekjiri force-pushed the fix/collection-logo-size branch from 1947a63 to 4e4d8dd Compare April 12, 2023 14:38
@jerabekjiri

jerabekjiri commented Apr 12, 2023

Copy link
Copy Markdown
Contributor Author

Screenshot from 2023-04-12 16-28-53
Screenshot from 2023-04-12 16-29-11
Screenshot from 2023-04-12 16-29-26
Screenshot from 2023-04-12 16-29-39

@jerabekjiri jerabekjiri merged commit 9be21de into ansible:master Apr 13, 2023
@patchback

patchback Bot commented Apr 13, 2023 •
edited
Loading

Copy link
Copy Markdown

Backport to stable-4.7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.7/9be21de76d3ae2a9d38706515897b4055e4ded84/pr-3567

Backported as #3582

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Apr 13, 2023
@jerabekjiri @patchback
unlock logo size (#3567)
613d378 
Issue: AAH-2272
(cherry picked from commit 9be21de)
@patchback patchback Bot mentioned this pull request Apr 13, 2023
Merged
himdel pushed a commit that referenced this pull request Apr 13, 2023
@patchback @jerabekjiri
unlock logo size (#3567) (#3582)
987f380 
Issue: AAH-2272
(cherry picked from commit 9be21de)

Co-authored-by: Jiří Jeřábek <Jerabekjirka@email.cz>
@github-actions github-actions Bot added the backported-4.7 This PR has been backported to stable-4.7 (2.4) label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himdel himdel himdel approved these changes

+1 more reviewer

@newswangerd newswangerd newswangerd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-4.7 This PR should be backported to stable-4.7 (2.4) backported-4.7 This PR has been backported to stable-4.7 (2.4)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerabekjiri @himdel @newswangerd