Restyle collection list item controls to keep alignment#3603
Merged
Conversation
…ng repository name lengths Issue: AAH-2303
9d59a38 to
ab24eea
Compare
jerabekjiri
approved these changes
Apr 17, 2023
jerabekjiri
left a comment
Contributor
There was a problem hiding this comment.
very nice, didn't think of this, LGTM 👍
This comment was marked as outdated.
This comment was marked as outdated.
jerabekjiri
pushed a commit
to jerabekjiri/ansible-hub-ui
that referenced
this pull request
Apr 17, 2023
jerabekjiri
added a commit
to jerabekjiri/ansible-hub-ui
that referenced
this pull request
Apr 17, 2023
jerabekjiri
pushed a commit
to jerabekjiri/ansible-hub-ui
that referenced
this pull request
Apr 17, 2023
…ng repository name lengths (ansible#3603) Issue: AAH-2303 (cherry picked from commit 686ef1f)
jerabekjiri
pushed a commit
to jerabekjiri/ansible-hub-ui
that referenced
this pull request
Apr 17, 2023
…ng repository name lengths (ansible#3603) Issue: AAH-2303 (cherry picked from commit 686ef1f)
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2303
When repository names vary in length, collection list items (both in namespace detail and in collection list view (but not cards view)) end up with misaligned controls:
Namespace detail
before
after
Collection list
before
after
Fixing by unifying the rendering between the two, and rendering as a right-aligned block of column flex items, aligned to the right, with text inside aligned to the left.
flex-direction: columnalign-items: flex-endflex-direction: columnalign-items: flex-startflex-direction: rowalign-self: flex-start