Add Python 3 support to ovirt4 inventory script. #57824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3 only allows strings through the config parser. This is fine for the URL, Username, and Password since these values are required. The CA File is optional so an empty string is used in leiu of None in the config dictionary.
Contributor
Contributor
|
+1 |
Contributor
|
Please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html?#creating-a-changelog-fragment, thanks. |
Contributor
Author
|
I have added the changelog fragment. Thanks! |
rmkraus
added a commit
to rmkraus/awx
that referenced
this pull request
Jun 16, 2019
Pulling in the new ovirt4 dynamic inventory script that will be pulled in ansible/ansible#57824 Signed-off-by: Ryan Kraus <rmkraus@gmail.com>
samdoran
suggested changes
Jun 19, 2019
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - ovirt3 inventory - Updated the dynamic inventory script for Python 3 support | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - ovirt3 inventory - Updated the dynamic inventory script for Python 3 support | |
| - ovirt4 inventory - Updated the dynamic inventory script for Python 3 support |
Contributor
Author
There was a problem hiding this comment.
Good catch, should be fixed now. 👍
Contributor
Author
|
Looks like the Shippable tests ran before the commit was made available. Is there a way to re-run it? It should check out fine. |
samdoran
approved these changes
Jun 21, 2019
Contributor
|
@rmkraus That happens sometimes. The GitHub CDN can be a bit slow to show new commits. We can rerun the tests or you can close/reopen the PR to trigger a new test run. |
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Jun 30, 2019
Python 3 only allows strings through the config parser. This is fine for the URL, Username, and Password since these values are required. The CA File is optional so an empty string is used in leiu of None in the config dictionary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Python 3 only allows strings through the config parser. This is fine for
the URL, Username, and Password since these values are required. The CA
File is optional so an empty string is used in lieu of None in the
config dictionary.
ISSUE TYPE
COMPONENT NAME
ovirt4
ADDITIONAL INFORMATION