Skip to content

Conversation

@d-little
Copy link
Contributor

SUMMARY

Fixes #51754

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

aix_devices

ADDITIONAL INFORMATION

Small PR. We check to see if devices was passed as 'all', and if it is, we just run cfgmgr on the remote host. If device is not 'all', run cfgmgr -l device instead.

]# ansible-playbook -vvvi /etc/ansible/test.ini -u deploy test_cfgmgr.yml
ansible-playbook 2.8.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible-playbook
  python version = 3.6.8 (default, Apr 25 2019, 21:02:35) [GCC 4.8.5 20150623 (Red Hat 4.8.5-36)]
Using /etc/ansible/ansible.cfg as config file
host_list declined parsing /etc/ansible/test.ini as it did not pass it's verify_file() method
script declined parsing /etc/ansible/test.ini as it did not pass it's verify_file() method
auto declined parsing /etc/ansible/test.ini as it did not pass it's verify_file() method
yaml declined parsing /etc/ansible/test.ini as it did not pass it's verify_file() method
Parsed /etc/ansible/test.ini inventory source with ini plugin

PLAYBOOK: test_cfgmgr.yml *********************************************************************************************************************************************************************************************************
1 plays in test_cfgmgr.yml

PLAY [Test cfgmgr] ***********************************************************************************************************************************************************************************************************************
META: ran handlers

TASK [Test 'bare' cfgmgr] ****************************************************************************************************************************************************************************************************************
task path: /etc/ansible/test_cfgmgr.yml:8
~~~snip~~~
changed: [AIXTEST] => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/bin/python"
    },
    "changed": true,
    "invocation": {
        "module_args": {
            "attributes": null,
            "device": "all",
            "force": false,
            "recursive": false,
            "state": "available"
        }
    },
    "msg": ""
}

TASK [Test en0 scan] *

~~~SNIP~~~
<AIXSERVER> (0, b'\n{"msg": "", "invocation": {"module_args": {"device": "en0", "attributes": null, "state": "available", "force": false, "recursive": false}}, "changed": true}\n', b'')
changed: [AIXTEST] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "attributes": null,
            "device": "en0",
            "force": false,
            "recursive": false,
            "state": "available"
        }
    },
    "msg": ""
}
META: ran handlers
META: ran handlers

PLAY RECAP *******************************************************************************************************************************************************************************************************************************
AIXTEST                    : ok=2    changed=2    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0

@ansibot
Copy link
Contributor

ansibot commented Jul 15, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aix AIX community bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. python3 support:community This issue/PR relates to code supported by the Ansible community. system System category labels Jul 15, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 16, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 16, 2019
@d-little
Copy link
Contributor Author

d-little commented Jul 16, 2019

bot_status
ready_for_review

(CI failed due to issues with Github replication, trying to trigger a CI using the bot.. doesnt look like it, will submit an empty commit)

@ansibot
Copy link
Contributor

ansibot commented Jul 16, 2019

Components

lib/ansible/modules/system/aix_devices.py
support: community
maintainers: MorrisA bcoca d-little dagwieers flynn1973 gforster kairoaraujo marvin-sinister mator molekuul ramooncamacho wtcross

Metadata

waiting_on: d-little
changes_requested_by: null
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: unstable
shippable_status: failure
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 16, 2019
@ansibot ansibot added has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 24, 2019
@d-little
Copy link
Contributor Author

Bumping stale AIX PRs (thanks!) (Close/Reopen for CI checks)

@d-little d-little closed this Aug 26, 2019
@d-little d-little reopened this Aug 26, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 26, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 3, 2019
@gundalow
Copy link
Contributor

@mator Does this patch work OK for you, if so could you please add s h i p i t

@gundalow
Copy link
Contributor

@mator Hi, does this patch solve the problem you saw?

@mator
Copy link
Contributor

mator commented Feb 15, 2020

@gundalow thanks for a reminder, going to check and re-test this PR in a few days...

@gundalow gundalow self-assigned this Feb 15, 2020
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Mar 26, 2020
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@Akasurde
Copy link
Member

Akasurde commented Jul 3, 2020

@d-little Thank you very much for your interest in Ansible. This plugin/module is no longer maintained in this repository and has been migrated to community.general. Could you please migrate this PR to the above-mentioned repo?

If you have further questions please stop by IRC or the mailing list:

Thanks,

needs_info

@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Jul 6, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 8, 2020

@d-little This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects_2.9 This issue/PR affects Ansible v2.9 aix AIX community bot_closed bug This issue/PR relates to a bug. collection:community.general collection Related to Ansible Collections work has_issue module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. owner_pr This PR is made by the module's maintainer. python3 stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. system System category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discover of all devices fail in aix_devices.py module

5 participants