Skip to content

swdepot: Refactor code #51106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagwieers wants to merge 4 commits into from
Closed

swdepot: Refactor code #51106

dagwieers wants to merge 4 commits into from

Conversation

@dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Jan 20, 2019 •
edited
Loading

SUMMARY

This PR includes:

  • Add RETURN documentation
  • Fixes to the documentation and examples
  • Simplified logic
  • Set default state to 'present'
  • Add parameter dependencies
  • Use a result dictionary
  • Fix check-mode support
  • Added integration tests
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

swdepot

@dagwieers
swdepot: Refactor code
34e3144 
This PR includes:
- Fixes to the documentation and examples
- Simplified logic
- Set default state to 'present'
- Add parameter dependencies
- Use a result dictionary
- Fix check-mode support
@dagwieers dagwieers added the hpux HP-UX community label Jan 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2019

cc @bcoca @melodous
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 20, 2019
@ansibot
Copy link
Contributor

ansibot commented Jan 20, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added test This PR relates to tests. and removed owner_pr This PR is made by the module's maintainer. labels Jan 20, 2019
@dagwieers dagwieers mentioned this pull request Jan 20, 2019
Closed
@dagwieers
Copy link
Contributor Author

dagwieers commented Jan 29, 2019

@davx8342 Would it be possible to test swdepot from this branch, and I can help you create integration tests so we can test idempotency, check-mode and return values at every possible use.

@dagwieers dagwieers mentioned this pull request Jan 29, 2019
Merged
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 29, 2019
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Feb 6, 2019
samccann
samccann approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs portion LGTM

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Feb 11, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed shipit This PR is ready to be merged by Core labels Feb 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Feb 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/packaging/os/swdepot.py:0:0: E309 version_added for new option (depot) should be 1.4. Currently None
lib/ansible/modules/packaging/os/swdepot.py:0:0: E309 version_added for new option (name) should be 1.4. Currently None
lib/ansible/modules/packaging/os/swdepot.py:0:0: E309 version_added for new option (state) should be 1.4. Currently None

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Feb 11, 2019
@ansibot ansibot added the packaging Packaging category label Feb 19, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 19, 2019
@acozine
Copy link
Contributor

acozine commented Mar 6, 2019

Related to #47869.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Mar 6, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:community.general labels Apr 29, 2020
@ansibot ansibot added the needs_triage Needs a first human triage before being processed. label May 16, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 18, 2020
@mkrizek
Copy link
Contributor

mkrizek commented Aug 18, 2020

Thank you very much for your interest in Ansible. This plugin is no longer maintained in this repository and has been migrated to https://github.com/ansible-collections/community.general.

Please re-submit this issue in the above repository.

If you have further questions please stop by IRC or the mailing list:

@mkrizek mkrizek closed this Aug 18, 2020
@ansible ansible locked and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@samccann samccann samccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. collection:community.general collection Related to Ansible Collections work has_issue hpux HP-UX community module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. packaging Packaging category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dagwieers @ansibot @acozine @mkrizek @samccann