Do the grafana thing in docker-compose templating itself#12391
Merged
Conversation
kdelee
approved these changes
Jun 16, 2022
Member
|
One issue I've had is tearing down gafana/prometheus to start over if I've changed the scrape config. not sure we have a make docker-compose-clean target for awx either though, so its not like that is a regression |
Member
Author
|
I pushed another change that adds the volumes to |
fosterseth
reviewed
Jun 16, 2022
| container_name: tools_grafana_1 | ||
| hostname: splunk | ||
| ports: | ||
| - "3001:3000" |
Member
There was a problem hiding this comment.
for those wondering, I found that 3000 was conflicting with docker engine on my local machine, but which is why 3001 was chosen.
fosterseth
approved these changes
Jun 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
I'm following the pattern started by @john-westcott-iv here, and I find it vastly better quality-of-life than the existing idea of starting up independent containers.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
So far tested and works great