Skip to content

Revert "Remove trailing $ from websocket_urlpatterns to work with cus…#13645

Merged
TheRealHaoLiu merged 1 commit into
ansible:develfrom
TheRealHaoLiu:fix-websocket
Mar 3, 2023
Merged

Revert "Remove trailing $ from websocket_urlpatterns to work with cus…#13645
TheRealHaoLiu merged 1 commit into
ansible:develfrom
TheRealHaoLiu:fix-websocket

Conversation

@TheRealHaoLiu

@TheRealHaoLiu TheRealHaoLiu commented Mar 3, 2023 •
edited by relrod
Loading

Copy link
Copy Markdown
Member

…tom path to fix #12241"

This reverts commit 5e28f5d.

SUMMARY

this undoes a change which caused wsbroadcast (wsrelay in the new world) to get routed to the event consumer instead of the relay consumer.

This showed up as this in the logs, but is not very useful to understanding what happened:

2023-03-02 21:00:06,837 ERROR    [-] awx.main.consumers Request user is not authenticated to use websocket.
2023-03-02 21:00:06,837 ERROR    [-] awx.main.consumers Request user is not authenticated to use websocket.
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
awx: 21.12.1.dev54+g2ca0b7bc01
ADDITIONAL INFORMATION

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge March 3, 2023 02:17
@TheRealHaoLiu TheRealHaoLiu merged commit f0c967c into ansible:devel Mar 3, 2023
@adpavlov

adpavlov commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown

I just retested it with latest awx 21.13.0 and custom ingress_path: /awx
As expected with default routing.py I got 500 Server error on WS in Firefox and output wasn't updated.

Once I added below to my deploy-awx.yml (the only difference is PR fix and removed trailing $):

  extra_volumes: |
    - name: routing
      hostPath: 
        path: "routing.py"
        type: File
  web_extra_volume_mounts: |
    - mountPath: /var/lib/awx/venv/awx/lib/python3.9/site-packages/awx/main/routing.py
      name: routing

I see in WS 101 status and output updated.

@adpavlov adpavlov mentioned this pull request Mar 7, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@relrod relrod relrod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Websocket not working at non-root path

3 participants

@TheRealHaoLiu @adpavlov @relrod