HostMetricSummaryMonthly command + scheduled task#13999
Merged
Conversation
0f57e16 to
b1f39ef
Compare
AlanCoding
reviewed
May 15, 2023
AlanCoding
reviewed
May 15, 2023
AlanCoding
reviewed
May 15, 2023
AlanCoding
reviewed
Jun 5, 2023
AlanCoding
reviewed
Jun 5, 2023
AlanCoding
reviewed
Jun 7, 2023
993e9c5 to
c5c8ac6
Compare
AlanCoding
reviewed
Jun 8, 2023
AlanCoding
reviewed
Jun 8, 2023
AlanCoding
reviewed
Jun 8, 2023
Member
|
👍 all discussions are pretty well resolved aside from some linter failure related items, so after those get cleaned up we'll be looking at final verification and merging. |
be157f4 to
8f7afd2
Compare
8f7afd2 to
5822529
Compare
5822529 to
1b62b4e
Compare
AlanCoding
approved these changes
Jun 30, 2023
AlanCoding
left a comment
Member
There was a problem hiding this comment.
wrapping up
- review discussions resolved
- checks are good
- integration test results reviewed
djyasin
approved these changes
Jul 5, 2023
Member
|
I have one minor bug fix I want to add to this branch: I'll wait for you to look over that, because I don't see a particular rush. After that I can work on next steps for shipping this. |
jjwatt
suggested changes
Jul 5, 2023
jjwatt
left a comment
Contributor
There was a problem hiding this comment.
Reviewed for Python readability. I have a couple of nitpicks around comments, etc.
jjwatt
approved these changes
Jul 11, 2023
Member
|
Ready to rebase and merge. |
82921b9 to
aa96ea0
Compare
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds command
awx-manage host_metric_summary_monthlyAdds scheduled task
host_metric_summary_monthly(once per week)It computes last 36 months of HostMetricSummaryMonthly table (1 row == 1 month)
36 months is also threshold for deleting HostMetrics (will be implemented also to this feature branch)
It computes subscription consumption and unique hosts added/deleted in given month (more precisely HostMetrics)
It'll serve as a backend for UI table with graph of subscription consumption usage.
More described in the ADR
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION