Skip to content

AAP-13369 Python 3.9 -> 3.11 upgrade#14771

Merged
CFSNM merged 12 commits into
develfrom
AAP13369
Mar 13, 2024
Merged

AAP-13369 Python 3.9 -> 3.11 upgrade#14771
CFSNM merged 12 commits into
develfrom
AAP13369

Conversation

@dmzoneill
Copy link
Copy Markdown
Member

@dmzoneill dmzoneill commented Jan 16, 2024 •
edited
Loading

SUMMARY
  • This updates python version from 3.9 to 3.11

related #13820

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • n/a
AWX VERSION
  • n/a
ADDITIONAL INFORMATION
  • n/a

@dmzoneill dmzoneill marked this pull request as draft January 16, 2024 16:57
@AlanCoding
Copy link
Copy Markdown
Member

AlanCoding commented Jan 16, 2024

Note that there are some prior comments at #14257 which this replaces

@dmzoneill dmzoneill closed this Jan 17, 2024
@dmzoneill dmzoneill reopened this Jan 17, 2024
@dmzoneill dmzoneill force-pushed the AAP13369 branch 5 times, most recently from 8886d0e to 696632e Compare January 17, 2024 12:39
jjwatt
jjwatt reviewed Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jjwatt jjwatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are important:

  • don't use update-alternatives
  • don't refer to the bin as just python3; don't make it even more implicit than it already is

Comment thread Makefile Outdated
Comment thread requirements/README.md Outdated
Comment thread tools/ansible/roles/dockerfile/templates/Dockerfile.j2 Outdated
Comment thread tools/ansible/roles/dockerfile/templates/Dockerfile.j2 Outdated
@dmzoneill dmzoneill force-pushed the AAP13369 branch 8 times, most recently from bab640b to 82766cd Compare January 17, 2024 17:43
@jjwatt
Copy link
Copy Markdown
Contributor

jjwatt commented Jan 18, 2024 •
edited
Loading

I edited a couple comments. Added a small optional change:
optional nit: github supports this, iirc:
RUN pip3 install black git+https://github.com/coderanger/supervisor-stdout .git@973ba19967cdaf46d9c1634d1675fc65b9574f6e
If you want to try that, my OCD will be a little happier :)
NOTE: speed boost, too! GitHub takes advantage of those shas to bundle/compress and cache.

@dmzoneill dmzoneill force-pushed the AAP13369 branch 3 times, most recently from 51c1689 to 44e2b0d Compare January 18, 2024 13:46
@dmzoneill
Copy link
Copy Markdown
Member Author

dmzoneill commented Jan 18, 2024 

bash-5.1$ pgrep -u 1000 | while read a; do echo -n "$a "; readlink /proc/$a/exe; done | grep python
248 /usr/bin/python3.11
249 /usr/bin/python3.11
250 /usr/bin/python3.11
251 /usr/bin/python3.11
252 /usr/bin/python3.11
257 /usr/bin/python3.11
261 /usr/bin/python3.11
263 /usr/bin/python3.11
264 /usr/bin/python3.11
403 /usr/bin/python3.11
484 485 486 487 /usr/bin/python3.11
494 /usr/bin/python3.11
496 /usr/bin/python3.11
498 /usr/bin/python3.11
505 /usr/bin/python3.11
506 /usr/bin/python3.11
507 /usr/bin/python3.11
508 /usr/bin/python3.11

jjwatt
jjwatt previously approved these changes Jan 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jjwatt jjwatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please update the doc and/or drop that patch & do it in a followup.

Comment thread Makefile Outdated
Comment thread tools/ansible/roles/dockerfile/templates/Dockerfile.j2
@dmzoneill dmzoneill changed the title Draft: AAP-13369 Python 3.9 -> 3.11 upgrade AAP-13369 Python 3.9 -> 3.11 upgrade Jan 19, 2024
@dmzoneill dmzoneill marked this pull request as ready for review January 19, 2024 12:13
@dmzoneill dmzoneill force-pushed the AAP13369 branch 2 times, most recently from 328977f to bbefee1 Compare January 19, 2024 12:23
@CFSNM CFSNM force-pushed the AAP13369 branch 12 times, most recently from 1cf5eff to 8f10c66 Compare February 28, 2024 12:46
@CFSNM CFSNM marked this pull request as ready for review February 28, 2024 12:47
CFSNM
CFSNM previously approved these changes Mar 5, 2024
View reviewed changes
@flku-snp flku-snp mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu approved these changes

@gundalow gundalow Awaiting requested review from gundalow

@jessicamack jessicamack Awaiting requested review from jessicamack

@AlanCoding AlanCoding Awaiting requested review from AlanCoding

@simaishi simaishi Awaiting requested review from simaishi

@jjwatt jjwatt Awaiting requested review from jjwatt

+1 more reviewer

@CFSNM CFSNM CFSNM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api component:cli dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dmzoneill @AlanCoding @jjwatt @gundalow @CFSNM @TheRealHaoLiu