Adjust the awx-manage script to make use of importlib#15015
Merged
TheRealHaoLiu merged 2 commits intoApr 2, 2024
Conversation
removing the deprecation warning.
No longer need to rebuild docker-compose devel image to load change for `tools/docker-compose/awx-manage` in development environment
TheRealHaoLiu
approved these changes
Apr 2, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* Adjust the awx-manage script to make use of importlib removing the deprecation warning. * Synlink awx-manage in docker-compose No longer need to rebuild docker-compose devel image to load change for `tools/docker-compose/awx-manage` in development environment --------- Co-authored-by: Hao Liu <44379968+TheRealHaoLiu@users.noreply.github.com>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
* Adjust the awx-manage script to make use of importlib removing the deprecation warning. * Synlink awx-manage in docker-compose No longer need to rebuild docker-compose devel image to load change for `tools/docker-compose/awx-manage` in development environment --------- Co-authored-by: Hao Liu <44379968+TheRealHaoLiu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
removing the deprecation warning.
pkg_resources is now deprecated, so it has been throwing a DeprecationWarning since we've upgraded to Python 3.11. It's recommended to use importlib instead, which has a couple of functions in importlib.metadata that could be used for this purpose (
distributionorentry_points).The annoying part of this PR was discovering that
.egg-linkfiles were not a standardized part of Python, and were only supported by setuptools..pthfiles seem to work, though, so I've changed the editable dev environment reference to make use of that instead.ISSUE TYPE
COMPONENT NAME