Re-parent DAB views from AWX base#15019
Merged
Merged
Conversation
jessicamack
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Peeling this off from the RBAC branch, because we got word that other people were experiencing strange 403 errors when a 401 was expected. I ran into that exact thing a while ago and tore my hair out from it for 1/2 of a day. The issue is that DRF has a header-generator for errors, which call back to the authentication plugin. The issue is that we inserted the JWT auth in the front of our authentication plugin list.
This never mattered for AWX because its parent view just went and attached its own darn header to error responses and bypassed that code. But for DAB views, that never applied. Now we will make it so, by using this setting to get DAB to make its own views a subclass of AWX views.
This has been stable enough in the RBAC branch, it should rightfully be peeled off into devel branch.
ISSUE TYPE
COMPONENT NAME