Skip to content

Add TACACS to dump_auth_config command#15111

Closed
jessicamack wants to merge 7 commits into
ansible:develfrom
jessicamack:add-tacacs-auth-config-dump
Closed

Add TACACS to dump_auth_config command#15111
jessicamack wants to merge 7 commits into
ansible:develfrom
jessicamack:add-tacacs-auth-config-dump

Conversation

@jessicamack
Copy link
Copy Markdown
Member

@jessicamack jessicamack commented Apr 15, 2024 •
edited
Loading

SUMMARY

dump_auth_config will now also dump TACACS config data.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • Other
AWX VERSION
awx: 24.2.1.
ADDITIONAL INFORMATION

if TACACS is not configured

    {
        "TACACS_missing_fields": [
            "HOST",
            "SECRET"
        ]
    }

if TACACS is configured

    {
        "type": "ansible_base.authentication.authenticator_plugins.tacacs",
        "name": "TACACS",
        "enabled": true,
        "create_objects": true,
        "users_unique": false,
        "remove_users": true,
        "configuration": {
            "HOST": "localhost",
            "PORT": 49,
            "AUTH_PROTOCOL": "ascii",
            "REM_ADDR": false,
            "SECRET": "test",
            "SESSION_TIMEOUT": 5
        }
    }

@jessicamack
add TACACS config dump
e535b3b 
Signed-off-by: jessicamack <jmack@redhat.com>
@jessicamack jessicamack marked this pull request as draft April 15, 2024 14:03
@jessicamack
Copy link
Copy Markdown
Member Author

jessicamack commented Apr 15, 2024

Converting to draft because I'll be adding the feedback changes from #15106

@jessicamack jessicamack marked this pull request as ready for review April 22, 2024 14:42
jbradberry
jbradberry suggested changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feedback on this PR is the same as #15134. The current behavior of self.is_enabled() is a potential bug due to considering any explicit but false-evaluating entries the same as a missing key-value pair.

@fosterseth fosterseth requested review from fosterseth June 17, 2024 19:50
@tvo318
Copy link
Copy Markdown
Member

tvo318 commented Apr 2, 2025

Closing these series of PRs.. @jessicamack is unable to reproduce "potential error" - This branch is still available if needed to reopen in the future.

@tvo318 tvo318 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrismeyersfsu chrismeyersfsu Awaiting requested review from chrismeyersfsu

@john-westcott-iv john-westcott-iv Awaiting requested review from john-westcott-iv

@TheRealHaoLiu TheRealHaoLiu Awaiting requested review from TheRealHaoLiu

@fosterseth fosterseth Awaiting requested review from fosterseth

1 more reviewer

@jbradberry jbradberry jbradberry requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jessicamack @tvo318 @jbradberry