Fix success_url_allowed_hosts set instantiation#15196
Merged
Merged
Conversation
rooftopcellist
approved these changes
May 16, 2024
jessicamack
approved these changes
May 16, 2024
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
Co-authored-by: Michael Anstis <manstis@redhat.com>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Michael Anstis <manstis@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Further to #15148
This PR fixes parsing of the injected setting value.
I've tested with a locally built AWX image deployed to OpenShift and verified various scenarios now work correctly.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
The injection of
spec.extra_settingsinto Django'ssettingswas adding the value as a set of characters.This PR corrects handling of the setting to use a set of parsed, comma separated, values.