Improve logging for starting jobs and test cleanup #16201
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a mop-up of any remaining issues I saw while trying to do performance testing related to dispatcherd.
We had a case where scale-ups could result in missed messages, making these messages really important. Although the lost messages were recovered, it was still a pretty bad bug. It should be fixed now, but the logs are also valuable to keep.
This also adds some re-scheduling logic, which is going off of a gut intuition more than anything else. This did not ever cause a delay in job starting, and in practice it was always quite fast.
ISSUE TYPE
COMPONENT NAME
Note
Batch-dispatch up to 25 waiting jobs with timing/id logging and self-reschedule; update bulk job launch test to override max launch setting.
dispatch_waiting_jobsinawx/main/tasks/jobs.py:waitingjobs per run.awx/main/tests/functional/test_bulk.py:test_bulk_job_launch_queriesusesoverride_settings(BULK_JOB_MAX_LAUNCH=num_jobs + 1)to allow requested job count.Written by Cursor Bugbot for commit f903aad. This will update automatically on new commits. Configure here.