Skip to content

Conversation

@AlanCoding
Copy link
Member

@AlanCoding AlanCoding commented Dec 10, 2025

SUMMARY

Try to reduce number of warnings in output

2025-12-09T02:33:49.7952640Z  �[33m8 warnings found (use docker --debug to expand):
2025-12-09T02:33:49.7953629Z �[0m - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 14)
2025-12-09T02:33:49.7954700Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 85)
2025-12-09T02:33:49.7955768Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 86)
2025-12-09T02:33:49.7957167Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 87)
2025-12-09T02:33:49.7958346Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 88)
2025-12-09T02:33:49.7959273Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 11)
2025-12-09T02:33:49.7960308Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 12)
2025-12-09T02:33:49.7962242Z  - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 13)

from image build, because it distracts from other troubleshooting

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

Note

Switches Dockerfile ENV declarations to key=value format in builder and final stages to reduce linter warnings.

  • Dockerfile Template (tools/ansible/roles/dockerfile/templates/Dockerfile.j2)
    • Update ENV instructions to key=value format in both the builder and final stages for LANG, LANGUAGE, LC_ALL, and AWX_LOGGING_MODE.

Written by Cursor Bugbot for commit 42140ed. This will update automatically on new commits. Configure here.

@sonarqubecloud
Copy link

@AlanCoding AlanCoding requested a review from djyasin December 15, 2025 19:28
@AlanCoding
Copy link
Member Author

Can't find "LegacyKeyValueFormat" in the output from the checks.

#51 [stage-2 33/34] RUN for dir in       /var/lib/awx       /var/lib/awx/rsyslog       /var/lib/awx/rsyslog/conf.d       /var/lib/awx/.local/share/containers/storage       /var/run/awx-rsyslog       /var/log/nginx       /var/lib/pgsql       /var/run/supervisor       /var/run/awx-receptor       /var/lib/nginx ;     do mkdir -m 0775 -p $dir ; chmod g+rwx $dir ; chgrp root $dir ; done &&     for file in       /etc/subuid       /etc/subgid       /etc/group       /etc/passwd       /var/lib/awx/rsyslog/rsyslog.conf ;     do touch $file ; chmod g+rw $file ; chgrp root $file ; done
#51 DONE 0.2s

#52 [stage-2 34/34] RUN for dir in       /var/lib/awx/.local       /var/lib/awx/venv       /var/lib/awx/venv/awx/bin       /var/lib/awx/venv/awx/lib/python3.11       /var/lib/awx/venv/awx/lib/python3.11/site-packages       /var/lib/awx/projects       /var/lib/awx/rsyslog       /var/run/awx-rsyslog       /.ansible       /var/lib/shared/overlay-images       /var/lib/shared/overlay-layers       /var/lib/shared/vfs-images       /var/lib/shared/vfs-layers       /var/lib/awx/vendor ;     do mkdir -m 0775 -p $dir ; chmod g+rwx $dir ; chgrp root $dir ; done &&     for file in       /var/lib/shared/overlay-images/images.lock       /var/lib/shared/overlay-layers/layers.lock       /var/lib/shared/vfs-images/images.lock       /var/lib/shared/vfs-layers/layers.lock       /var/run/nginx.pid;     do touch $file ; chmod g+rw $file ; done &&     echo "\setenv PAGER 'less -SXF'" > /var/lib/awx/.psqlrc
#52 DONE 0.2s

#53 exporting to image
#53 exporting layers
#53 exporting layers 41.2s done
#53 preparing layers for inline cache 0.0s done
#53 writing image sha256:9eb0b185302d6d083baeb82b25a5095a455df08340c2deeda7ec1287b129a832 done
#53 naming to ghcr.io/ansible/awx_devel:devel done
#53 DONE 41.2s

Seems boring?

@jessicamack jessicamack self-requested a review December 16, 2025 14:25
@AlanCoding AlanCoding merged commit 7a58377 into ansible:devel Dec 16, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants