[WIP] Move to dispatcherd #16209
Draft
[WIP] Move to dispatcherd #16209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* started removing feature flags and adjusting logic * WIP
AlanCoding
reviewed
Dec 17, 2025
awx/main/dispatch/publish.py
Outdated
| return obj | ||
|
|
||
| @classmethod | ||
| def apply_async(cls, args=None, kwargs=None, queue=None, uuid=None, **kw): |
Member
There was a problem hiding this comment.
I don't think we should need to keep this. I mean, I don't think we should need to keep any of the entire publish.py module.
Member
|
Looking like it's making good progress. Next I would like to try to focus on the decorator transition awx/awx/main/scheduler/tasks.py Line 10 in d7eb714 Should be something that can be replaced now with the |
* moved to dispatcher decorator * updated as many as I could find
AlanCoding
reviewed
Dec 19, 2025
| timeout = 5 | ||
| if flag_enabled('FEATURE_DISPATCHERD_ENABLED'): | ||
| from dispatcherd.factories import get_control_from_settings | ||
| from dispatcherd.factories import get_control_from_settings |
Member
There was a problem hiding this comment.
At this point, it should be appropriate to move imports like this up to the top of the file. The argument for doing it in-line because it's a conditional path no longer holds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removing the dispatcher feature flag as well as migrating anything that might be needed to new dispatcherd library.
PR is still a WIP and not finished. If you see anything or think of anything please note it.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION