Resolve default ordering warnings from tests#3820
Merged
softwarefactory-project-zuul[bot] merged 1 commit intoMay 20, 2019
Merged
Conversation
Contributor
|
Build failed.
|
3da9991 to
e8a0bf1
Compare
Contributor
|
Build succeeded.
|
rooftopcellist
approved these changes
May 3, 2019
rooftopcellist
left a comment
Member
There was a problem hiding this comment.
Thank you for this! All of the order_by's make sense.
| serializer_class = serializers.UserSerializer | ||
| parent_model = models.Role | ||
| relationship = 'members' | ||
| ordering = ('username',) |
Member
There was a problem hiding this comment.
We could alternatively do this on the model, which would be more concise.
Member
Author
There was a problem hiding this comment.
I agree entirely for the OAuth2 models, because we maintain those. Pushed a commit that does this.
But we don't have a User model inside of our app, so I want to keep these for that model, and only that model.
e8a0bf1 to
a8cce4f
Compare
Contributor
|
Build succeeded.
|
Member
Author
|
Blocked, as the migration claim is not settled |
Contributor
|
This is probably unblocked once something like #3842 is merged. |
Contributor
|
Not blocked anymore 👀 |
a8cce4f to
867cf8d
Compare
Contributor
|
Build failed.
|
867cf8d to
f4c1884
Compare
Contributor
|
Build succeeded.
|
Member
Author
|
Got test output, and only remaining warning is: From some googling on this problem, it might be platform-specific, and anyway, it's probably harmless and related to the python stdlib logging. |
Contributor
|
Build succeeded (gate pipeline).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The tests were giving warnings
There were a lot of them. After this there should be none.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
In some cases, we can't modify the
Metaof the model, because it is not our model.Because of that, I borrowed the closest thing to the standard pattern from DRF:
https://github.com/encode/django-rest-framework/blob/14fad0d6902550cd61fc07370759ef785effa207/rest_framework/filters.py#L186-L190
So when you see the
orderingparameter set on a view, you should know that I did not invent that.