provide better HTTP responses for certain OAuth2 error scenarios#5477
Merged
softwarefactory-project-zuul[bot] merged 1 commit intoDec 10, 2019
Merged
Conversation
Contributor
Author
|
Before: After: |
Contributor
|
Build succeeded.
|
1eb6474 to
039f570
Compare
ryanpetrello
commented
Dec 10, 2019
| Context manager executing transaction.on_commit() hooks immediately as | ||
| if the connection was in auto-commit mode. | ||
| """ | ||
| def on_commit(func): |
Contributor
Author
There was a problem hiding this comment.
Contributor
|
Build succeeded.
|
039f570 to
5fb69d7
Compare
attempting to use an OAuth2 token as an externally authenticated user throws an HTTP 500 error when external oauth is disabled - this change improves that so it's a 401 Unauthorized instead.
5fb69d7 to
12a8793
Compare
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded (gate pipeline).
|
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Dec 13, 2019
ryanpetrello
added a commit
to ryanpetrello/awx
that referenced
this pull request
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to use an OAuth2 token as an externally authenticated user throws an HTTP 500 error when external oauth is disabled - this change improves that so it's a 401 Unauthorized instead.