-
Notifications
You must be signed in to change notification settings - Fork 665
Remove scenario name from molecule.yml #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ansible-zuul
merged 2 commits into
ansible:master
from
ssbarnea:fix/2434-remove-scenario-name
Feb 16, 2020
Merged
Remove scenario name from molecule.yml #2556
ansible-zuul
merged 2 commits into
ansible:master
from
ssbarnea:fix/2434-remove-scenario-name
Feb 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A missing playbook does not mean no verification is to be done for any verifiers. For example TestInfra verifier does not use a playbook. Still, a missing verify.yml when using Ansible Verifier will be considered a skip with warning. Fixes: 2543
564bfc6 to
8177953
Compare
Scenario name is now always the folder name containing the molecule.yml and can no longer be configured in-file. Remove scenario.name from v2 configuration files to avoid getting an error. This will allow us to refactor molecule, making it faster and not forcing it to parse all scenarios in order to later run only one. Fixes: ansible#2434
Contributor
|
Build succeeded.
|
8177953 to
96318d5
Compare
Contributor
|
Build succeeded.
|
Contributor
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario name is now always the folder name containing the molecule.yml and
can no longer be configured in-file.
Remove scenario.name from v2 configuration files to avoid getting an error.
This will allow us to refactor molecule, making it faster and not
forcing it to parse all scenarios in order to later run only one.
Fixes: #2434