Skip to content

Re-add credentials to Docker registry schema #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhan9san merged 3 commits into from
Oct 27, 2022
Merged

Re-add credentials to Docker registry schema #3706

zhan9san merged 3 commits into from
Oct 27, 2022

Conversation

@TheLastProject
Copy link
Contributor

@TheLastProject TheLastProject commented Oct 26, 2022 •
edited
Loading

This allows logging into a registry again like Molecule 4.0.1 allowed

I noticed that upgrading from molecule 4.0.1 to 4.0.2 at work broke our ability to use containers on a private Docker registry (in our case, a private GitLab registry).

The specific error message we started receiving was:

["Additional properties are not allowed ('credentials' was unexpected)"]

I came to the conclusion this was most likely broken by accident given:

  1. The option does work (removing the option from our molecule.yml gave us permission errors)
  2. There was nothing in the CHANGELOG about Docker registries
  3. Comparing release 4.0.1 to 4.0.2 showed nothing related to Docker registries either: v4.0.1...v4.0.2
  4. The old schema on release 4.0.1 contained these options: https://github.com/ansible-community/molecule/blob/v4.0.1/src/molecule/model/schema_v3.py#L245-L258
  5. This feature previously received fixes: Validation for registry credentials (password) blocks passing actual credential value to underlying playbook #1331

@TheLastProject TheLastProject requested review from a team as code owners October 26, 2022 12:22
@TheLastProject TheLastProject requested review from cidrblock, ganeshrn, greg-hellings, jseguillon and trishnaguha and removed request for a team October 26, 2022 12:22
@github-actions github-actions bot added the bug label Oct 26, 2022
@zhan9san
Copy link
Contributor

zhan9san commented Oct 26, 2022

@TheLastProject

Thanks for your contribution.
It looks good.

Would you mind taking a look at failed ci test?

It's not related to your change.

@TheLastProject
Copy link
Contributor Author

TheLastProject commented Oct 26, 2022

Sorry, I have no clue what could possibly be causing these test failures

@TheLastProject
Re-add credentials to Docker registry schema
bbfaba8 
Allows logging into a registry again like Molecule 4.0.1 allowed
@TheLastProject TheLastProject force-pushed the fix/reallow_registry_login branch from ff1016c to bbfaba8 Compare October 27, 2022 07:55
@zhan9san zhan9san merged commit c04706c into ansible:main Oct 27, 2022
davedittrich pushed a commit to davedittrich/molecule that referenced this pull request Dec 4, 2022
@TheLastProject @zhan9san @davedittrich
Re-add credentials to Docker registry schema (ansible#3706)
21062b9 
Allows logging into a registry again like Molecule 4.0.1 allowed

Co-authored-by: Jack <jack4zhang@gmail.com>
@cs35-owncloud
Copy link

cs35-owncloud commented Dec 28, 2022

It seems to work with molecule 4.0.4 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greg-hellings greg-hellings Awaiting requested review from greg-hellings greg-hellings was automatically assigned from ansible-community/molecule

@jseguillon jseguillon Awaiting requested review from jseguillon jseguillon was automatically assigned from ansible-community/molecule

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn was automatically assigned from ansible-community/devtools

@trishnaguha trishnaguha Awaiting requested review from trishnaguha trishnaguha was automatically assigned from ansible-community/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock cidrblock was automatically assigned from ansible-community/devtools

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validation for registry credentials (password) blocks passing actual credential value to underlying playbook

3 participants

@TheLastProject @zhan9san @cs35-owncloud