Add ansible_test_platform option to tox.ini#131
Merged
Conversation
Fixes #130 This patch adds a new parameter to the tox.ini configuration that allows users to choose whether tox-ansible should try to automatically detect an appropiate platform for ansible-test.
greg-hellings
approved these changes
May 20, 2022
Contributor
|
This is great. Thanks! |
Contributor
|
I don't think CI will finish before I have time to merge it this afternoon, but I will get it merged and released over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130
This patch adds a new parameter to the tox.ini configuration that allows users to choose whether tox-ansible should try to automatically detect an appropiate platform for ansible-test.
As suggested, I also added some assertion logic to ensure that the platform is always a valid choice.
I assume that you want this assertion in
options.py, so that any mistakes can be caught quickly upon reading the config file.Please let me know If that is not the case!