Use pre-commit when detected, otherwise use built-in lint#134
Merged
Conversation
Remove explicit call to yamllint unless the user has a yamllint configuration set. Otherwise, allow ansible-lint to handle that directly (ansible-lint does not allow configuration of a non-standard yamllint configuration file path, hence allowing for this flexibility) Add support for detection of pre-commit configuration. If that is detected, then the `lint_all` step simply calls the configured `pre-commit` command.
b150852 to
1fecb8f
Compare
Contributor
Author
|
@ssbarnea - does this look like it hits your pre-commit lint goals? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit call to yamllint unless the user has a yamllint
configuration set. Otherwise, allow ansible-lint to handle that directly
(ansible-lint does not allow configuration of a non-standard yamllint
configuration file path, hence allowing for this flexibility)
Add support for detection of pre-commit configuration. If that is
detected, then the
lint_allstep simply calls the configuredpre-commitcommand.