-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Migrate _pill.scss to Tailwlind #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into pill-migration
|
@Mit-Patwa Pushed a couple of cleanup commits (was easier than leaving comments!) and I also noticed a bug with the Discover menus - on main the shadow is white but here the shadow is black. Could you check? |
|
@binary-koan sorry for the late reply ,I was a little caught up. |
|
@binary-koan _a assigning this to you since you reviewed the previous PRs, let me know if you can't though. |
|
@binary-koan I was able to get the black shadow, this happens when I clicked on one of the discover categories for the first time, this was happening because of |
|
@binary-koan can we merge? |
|
Sorry for the wait, will hopefully get to this tomorrow |
|
Okay! I’m just a little excited since it’s my first merge :) |
|
Could you check if the failing tests are related? |
|
@binary-koan a bunch of tests are failing because of changed formatting, (No visual changes) What's the best approach? just modifying the test cases to expect: |
|
The |
|
@binary-koan could you help me out with the test cases,when I try to run the failing tests locally, I get a 502 bad gateway error before the testing even starts , because of which I get false test failures.What's the solution? |
|
@binary-koan could you trigger CI the tests should pass now, also I noticed you changed some of the tailwind utilities in the cleanup commits , did they work fine? |
|
Added a couple of minor fixes (realised my cleanup did break the small pill styles, my bad ...), will go ahead and merge now. Thanks again for the contribution! |
|
Awesome!!!Thanks for my first merge,what's the process for claiming the bounty? |
Part of: #1055
Previous PR's: #2073 #1865 , #1943
Description
This PR removes the legacy
_pill.scssfile and replaces it with a React component implementation (Pill.tsx) styled using Tailwind CSS utility classes.Changes Made
_pill.scs.AI Disclosure
PillcomponentNote: Have watched 2 Gumroad PR live streams end to end
Visual Comparison(No visual changes)
Dark Mode
Light Mode