fix: auto-refresh OAuth token for models API calls #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AgentProviderResolver for models fetching to ensure OAuth tokens are automatically refreshed before expiry, consistent with chat calls. Fixes #2017 Co-Authored-By: ForgeCode <noreply@forgecode.dev>
tusharmath
reviewed
Nov 28, 2025
crates/forge_api/src/forge_api.rs
Outdated
| .await | ||
| .context("Failed to fetch models")?; | ||
|
|
||
| Ok(self.services.models(provider).await?) |
Collaborator
There was a problem hiding this comment.
The service should guarantee in this case, that creds will be refreshed. Caller should not be responsible.
tusharmath
requested changes
Nov 28, 2025
crates/forge_api/src/forge_api.rs
Outdated
| ) | ||
| .await?) | ||
| // Use AgentProviderResolver to ensure OAuth tokens are refreshed if needed | ||
| let agent_provider_resolver = AgentProviderResolver::new(self.services.clone()); |
Collaborator
There was a problem hiding this comment.
Remove cred related code from ProviderResolver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use
AgentProviderResolverfor models fetching to ensure OAuth tokens are automatically refreshed before expiry, consistent with chat calls.Details
get_models()method to useAgentProviderResolver::get_provider(None)Fixes #2017
Co-Authored-By: ForgeCode noreply@forgecode.dev