Skip to content

Support Match mpls_tc #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
XiaoYiXiaoYang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Match mpls_tc #27

XiaoYiXiaoYang wants to merge 1 commit into from

Conversation

@XiaoYiXiaoYang
Copy link

@XiaoYiXiaoYang XiaoYiXiaoYang commented Mar 17, 2022

  • match mpls_tc value

This patch depend on another patch in libOpenflow:
antrea-io/libOpenflow#20

Signed-off-by: XiaoYiXiaoYang 1409026014@qq.com

@XiaoYiXiaoYang
Copy link
Author

XiaoYiXiaoYang commented Mar 17, 2022

@tnqn @wenyingd can you help to review this PR? Thanks!

@commandgjj
Copy link

commandgjj commented Mar 18, 2022

@tnqn @wenyingd can you help to review this PR? Thanks!

@wenyingd @tnqn We have verified patch series functions in our code. Please help review, thanks!

@tnqn tnqn requested a review from wenyingd March 18, 2022 15:20
wenyingd
wenyingd previously approved these changes Mar 30, 2022
View reviewed changes
Copy link

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyingd
Copy link

wenyingd commented Mar 30, 2022

Please resolve golangci failure first.

@XiaoYiXiaoYang
Copy link
Author

XiaoYiXiaoYang commented Mar 30, 2022

Please resolve golangci failure first.
@wenyingd

This patch depend on another patch in libOpenflow:
antrea-io/libOpenflow#20

it is the failure reason for golangci test,
please review it firstly, Thanks !

@XiaoYiXiaoYang XiaoYiXiaoYang force-pushed the support_match_mplstc branch 4 times, most recently from 3a4d8cc to 31639b0 Compare March 31, 2022 11:39
@XiaoYiXiaoYang
Copy link
Author

XiaoYiXiaoYang commented Mar 31, 2022 •
edited
Loading

Please resolve golangci failure first.

@wenyingd
I have resolved it, please review it again, thanks~

@XiaoYiXiaoYang XiaoYiXiaoYang requested a review from wenyingd March 31, 2022 11:49
tnqn
tnqn reviewed Mar 31, 2022
View reviewed changes
@XiaoYiXiaoYang XiaoYiXiaoYang requested a review from tnqn March 31, 2022 12:41
@XiaoYiXiaoYang
Copy link
Author

XiaoYiXiaoYang commented Apr 6, 2022 •
edited
Loading

@tnqn can you help to review again? Thanks!

@XiaoYiXiaoYang
Support Match mpls_tc
abd297c 
- match mpls_tc value
- update dependent libOpenflow version

This patch depend on another patch in libOpenflow:
antrea-io/libOpenflow#20

Signed-off-by: XiaoYiXiaoYang <1409026014@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wenyingd wenyingd Awaiting requested review from wenyingd

@tnqn tnqn Awaiting requested review from tnqn

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XiaoYiXiaoYang @commandgjj @wenyingd @tnqn