GO-5800 Support sort by object relations #2666

KirillSto · 2025-08-29T08:50:45Z

https://linear.app/anytype/issue/GO-5800/support-sorting-by-object-relations

Right now any sort upon relations with format tag/status/object/file use object ids to calculate order of objects in subscription.
To support ordering by object names and orderIds of tags following changes were made:

dependency service collects infomation on object sorts for subscriptions and triggers subscription reorder in case objects of dependent subscription change its order (orderId/name) and these objects influence sort
orderMap is introduced. This struct handles orders of dependent objects and helps to compare objects between each other
UpdateOrderMap method is added to database.Order interface. It is triggered on dependant objects change and keeps orders relevant all the time

github-actions · 2025-09-02T14:16:50Z

New Coverage	46.1% of statements
Patch Coverage	86.0% of changed statements (257/299)

^{Coverage provided by https://github.com/seriousben/go-patch-cover-action}

…lations

deff7 · 2025-10-03T12:05:32Z

core/subscription/sorted.go

+		s.skl.Set(e, nil)
+	}
+
+	defer s.diff.reset()


It's a large chunk of complex duplicated code from onChange, let's extract it to function

Moved to separate method onSklChange

deff7 · 2025-10-03T12:07:26Z

core/subscription/sorted.go

+		return
+	}
+
+	entries := s.getActiveEntries()


you have to use all entries, not only the active

Thank you! Now first we retrieve all entries by iteration over SkipList elements from Front, only then reset Skiplist

deff7 · 2025-10-03T12:09:16Z

core/subscription/dep.go

 	return
 }

+func (ds *dependencyService) enregisterObjectSorts(subId string, sorts []database.SortRequest) {


maybe use verb register? It's much more common

deff7 · 2025-10-03T12:48:32Z

core/subscription/dep.go

+		return keys
+	}
+	for _, sort := range sorts {
+		keys = append(keys, sort.orderKey())


You can also use if !slices.Contains here, lo.Uniq is a much heavier operation

deff7 · 2025-10-03T12:50:05Z

core/subscription/dep.go

+		})
+	}
+
+	if len(sortRelations) != 0 {


len > 0 by code style

SortsMap was refactored

deff7 · 2025-10-03T12:54:10Z

core/subscription/dep.go

+						depIds = append(depIds, depId)
+					}
+					if isSortKey {
+						if ds.depOrderObjects[depId] == nil {


maybe extract it to a function?

deff7 · 2025-10-03T12:56:18Z

core/subscription/dep.go

+
+type sortsMap map[string][]sortKey // subId -> sortRelationKeys
+
+func (m sortsMap) getSortKey(subId string, key domain.RelationKey) (sortKey, bool) {


maybe add a symmetrical function setSortKeys?

SortsMap was refactored. Please take a look, maybe it is not necessary yet

deff7 · 2025-10-03T12:57:31Z

core/subscription/dep.go

+	return bundle.RelationKeyName
+}
+
+type sortsMap map[string][]sortKey // subId -> sortRelationKeys


Can we benefit from using a map for keys? It seems so

deff7 · 2025-10-07T11:29:26Z

core/subscription/dep.go

+		}
+	}
+
+	if hasName {


It will be simpler if you'll add case hasName && hasOrderId here

deff7 · 2025-10-07T11:41:15Z

core/subscription/sorted.go

-		return
+	s.afterId = ""
+	if err := s.setBeforeAndAfterElements(); err != nil {
+		panic(fmt.Errorf("failed to set before and after elements: %w", err))


why to panic here?

Replaced with log

deff7 · 2025-10-07T11:45:02Z

pkg/lib/database/order.go

+		return ""
+	}
+
+	var result string


Maybe use strings.Builder here?

Even with strings.Builder this code will be not effective as it could be. Consider using some kind of reusable buffer. Notice that this function is called inside a sorting procedure which has O(n*log n) worst case scenario .

It's better to use shared buffer here

deff7 · 2025-10-07T11:50:53Z

pkg/lib/database/order.go

+	var result string
+	for _, id := range ids {
+		if details, ok := m.data[id]; ok {
+			result += details.GetString(key)


This code implies that arrays [1,2,3] and [2,3,1] are not equal. Does it conform with business rules? Or maybe we must sort sets?

It is stated by products to sort by first value, so it works like that already

deff7 · 2025-10-07T11:56:13Z

pkg/lib/database/order.go

+		Value:       domain.StringList(idsToSet),
+	}}})
+	if err != nil {
+		log.Errorf("failed to query records to update orders: %v", err)


Consider returning the error and log it on a some upper level. Function will become slightly cleaner

deff7 · 2025-10-07T14:11:30Z

pkg/lib/database/filter.go

+		RelationKey: key,
+		Condition:   model.BlockContentDataviewFilter_NotEmpty,
+	}}}, func(details *domain.Details) {
+		targetIds = append(targetIds, details.GetStringList(key)...)


Maybe use a map here? Then build a slice from it

KirillSto added 2 commits August 26, 2025 14:18

GO-5800 tidy

18a09da

GO-5800 Support sort by tags WIP

140577f

KirillSto self-assigned this Aug 29, 2025

KirillSto added 4 commits September 1, 2025 13:01

GO-5800 Support sort by names of object relations

56e73e0

GO-5800 Introduce orderManager

aea5c38

GO-5800 Rename methods

e3030b9

GO-5800 Fix tests

e17b795

KirillSto marked this pull request as ready for review September 2, 2025 14:08

KirillSto requested review from deff7 and requilence September 3, 2025 09:39

KirillSto added 18 commits September 5, 2025 12:32

GO-5800 Use dep sub to control sorts

d834885

GO-5800 Rearrange dep svc methids

c2a26cf

GO-5800 Reorder all parent subs on particular key

3414019

GO-5800 Add depOrderObjects map

a0ca31c

GO-5800 Move order update logic to dep sub refill WIP

8aeb28a

GO-5800 Fix sub ids usage

f066bc8

GO-5800 Merge dev

0a1d662

GO-5800 Add order keys to dep sub

dc01b27

GO-5800 Fix test

2898460

GO-5800 Merge branch 'develop' into go-5800-support-sort-by-object-re…

04e641a

…lations

GO-5800 Introduce OrderStore and skl reset

dff5ddb

GO-5800 Transfer all logic to database.Order

99133c7

GO-5800 Set orders only for non-existing

a26d4a7

GO-5800 Make collection sub sortable

170b4e8

GO-5800 Minimize changes

0701912

GO-5800 Add tests

7257136

GO-5800 Rename method

5920cd1

GO-5800 Fix ordering for types

a198292

deff7 reviewed Oct 3, 2025

View reviewed changes

KirillSto added 3 commits October 3, 2025 16:57

GO-5800 Optimize objectsToMap

25ed3f5

GO-5800 Refactor sortsMap

6e49829

GO-5800 Fix comments

4876889

sashagood requested review from deff7 and removed request for requilence October 7, 2025 10:22

deff7 reviewed Oct 7, 2025

View reviewed changes

KirillSto added 2 commits October 7, 2025 16:03

GO-5800 Fix comments 2

5c38e85

GO-5800 Rm comment

7cca185

deff7 reviewed Oct 7, 2025

View reviewed changes

KirillSto added 3 commits October 10, 2025 13:05

GO-5800 Use buffer to reuse mem

f9787e9

GO-5800 Use map to collect target ids

c346112

GO-5800 Remove comments

ef751bc

deff7 approved these changes Oct 14, 2025

View reviewed changes

KirillSto added 2 commits October 14, 2025 10:22

GO-5800 Merge develop

1cae9cb

GO-5800 Fix lint

277b0a3

KirillSto merged commit 91785b1 into develop Oct 14, 2025
5 of 6 checks passed

KirillSto deleted the go-5800-support-sort-by-object-relations branch October 14, 2025 09:13

github-actions bot locked and limited conversation to collaborators Oct 14, 2025


		type sortsMap map[string][]sortKey // subId -> sortRelationKeys

		func (m sortsMap) getSortKey(subId string, key domain.RelationKey) (sortKey, bool) {

GO-5800 Support sort by object relations #2666

GO-5800 Support sort by object relations #2666

Uh oh!

Conversation

KirillSto commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deff7 Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deff7 Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

KirillSto commented Aug 29, 2025 •

edited

Loading

github-actions bot commented Sep 2, 2025 •

edited

Loading

deff7 Oct 3, 2025 •

edited

Loading

deff7 Oct 7, 2025 •

edited

Loading