make ReadonlyUint8Array fully immutable #1112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of ReadonlyUint8Array is incomplete because
.subarrayreturns a normalUint8Arrayand likewise the various methods that take a callback provide the array itself as aUint8Arrayas a third parameter.Additionally, new mutable methods were recently added that are not omitted by the current definiton.
I pioneered this implementation in my own SDK which also gives an explanation of wtf I am doing here.
And while I have your attention, you may be interested in my fork-svm package which is built on top of kit as a proper way to test Solana programs.