Skip to content

Merges PR #236, and another two smaller issues.#237

Merged
aous72 merged 3 commits into
masterfrom
common2openjph
Dec 24, 2025
Merged

Merges PR #236, and another two smaller issues.#237
aous72 merged 3 commits into
masterfrom
common2openjph

Conversation

@aous72
Copy link
Copy Markdown
Owner

@aous72 aous72 commented Dec 24, 2025

This is attempts to merge PR #236.

cary-ilm and others added 3 commits December 18, 2025 13:13
OpenJPH headers are included in application code via `#include
<openjph/ojph_version.h>`. The headers are expected to be in a folder
named "openjph". The cmake configuration places them there in the
installation step.

However, if OpenJPH is incorporated into an application via cmake's
`add_subdirectory`, there is no installation step, so there is no
"openjph" folder, leading the `#include <openjph/ojph_version.h>` to
fail.

Renaming the "common" directory to "openjph" resolves the build issue,
since the headers then live inside the source tree in a directory with
same name as the installation. The use of the "common" directory name
is entirely internal to the OpenJPH build, it has no impact on the
installation. The name should be arbitrary, so there should be no
downside to renaming it this way.

Signed-off-by: Cary Phillips <cary@ilm.com>
@aous72 aous72 changed the title Fixes test compilation issues. Merges PR #236, and another two smaller issues. Dec 24, 2025
@aous72 aous72 merged commit 4d4f4e8 into master Dec 24, 2025
16 checks passed
@aous72 aous72 deleted the common2openjph branch December 24, 2025 04:08
@aous72 aous72 restored the common2openjph branch December 24, 2025 04:18
@aous72 aous72 deleted the common2openjph branch December 24, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants