Merges PR #236, and another two smaller issues.#237
Merged
Conversation
OpenJPH headers are included in application code via `#include <openjph/ojph_version.h>`. The headers are expected to be in a folder named "openjph". The cmake configuration places them there in the installation step. However, if OpenJPH is incorporated into an application via cmake's `add_subdirectory`, there is no installation step, so there is no "openjph" folder, leading the `#include <openjph/ojph_version.h>` to fail. Renaming the "common" directory to "openjph" resolves the build issue, since the headers then live inside the source tree in a directory with same name as the installation. The use of the "common" directory name is entirely internal to the OpenJPH build, it has no impact on the installation. The name should be arbitrary, so there should be no downside to renaming it this way. Signed-off-by: Cary Phillips <cary@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is attempts to merge PR #236.