Fix StreamObserver object calls onCompleted() without first calling onNext() will fail. #15466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15466 +/- ##
============================================
- Coverage 60.94% 60.92% -0.02%
- Complexity 11451 11453 +2
============================================
Files 1888 1888
Lines 86363 86379 +16
Branches 12956 12958 +2
============================================
- Hits 52633 52627 -6
- Misses 28298 28309 +11
- Partials 5432 5443 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PTAL @oxsean |
oxsean
requested changes
Jun 18, 2025
oxsean
reviewed
Jun 18, 2025
...src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/Http1SseServerChannelObserver.java
Outdated
Show resolved
Hide resolved
…nNext() will fail.
A little diff.PTAL @oxsean |
oxsean
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
#15465
Checklist