JDK 25 ServiceLoader issue in JsonUtils #15751
Closed
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated loadExtensions method to improve JDK 25 compatibility by restructuring the loop to handle exceptions from ServiceLoader safely.
Refactor loadExtensions method for JDK 25 compatibility and improve exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR addresses the issue where running Apache Dubbo on JDK 25 could lead to a fatal
NoClassDefFoundErroror otherThrowablesduring the ServiceLoader iteration process withinJsonUtils.java. This incompatibility arises from behavioral changes in thejava.util.ServiceLoaderAPI in recent JDK versions, whereIterator.hasNext()can now throw exceptions when attempting to load a service provider that has missing dependencies.What is the effect of this change?
Without this fix, users running on JDK 25 (especially those not using a JSON framework that Dubbo expects) will experience application startup failure.
Detailed Fix
The
loadExtensions()method inJsonUtilshas been refactored from aforloop to a safewhile(true)loop. This allows both theit.hasNext()andit.next()calls to be wrapped in a singletry-catch (Throwable)block, safely skipping any broken service provider definitions without crashing the entire iteration process.Related Issue
Closes #15747