fix(aws): implement writer-version update in Glue sync client#18707
fix(aws): implement writer-version update in Glue sync client#18707deepakpanda93 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18707 +/- ##
============================================
- Coverage 68.14% 68.14% -0.01%
+ Complexity 29077 29075 -2
============================================
Files 2522 2522
Lines 141177 141184 +7
Branches 17514 17514
============================================
- Hits 96208 96205 -3
- Misses 37061 37069 +8
- Partials 7908 7910 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hudi-agent
left a comment
There was a problem hiding this comment.
🤖 This review was generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.
Thanks for the contribution! This PR implements the missing updateHoodieWriterVersion() in AWSGlueCatalogSyncClient so Glue sync no longer fails with UnsupportedOperationException on Hudi 1.2.x/1.3.0-SNAPSHOT. The implementation reuses the existing updateTableParameters helper and mirrors the equivalent HoodieHiveSyncClient behavior. No correctness issues found. A few style/readability suggestions in the inline comments. Please take a look, and this should be ready for a Hudi committer or PMC member to take it from here. One small wording nit in the new error message.
cc @yihua
| Collections.singletonMap(HoodieVersion.HOODIE_WRITER_VERSION, HoodieVersion.get()), | ||
| skipTableArchive); | ||
| } catch (Exception e) { | ||
| throw new HoodieGlueSyncException(String.format("Failed to update hudi writer major version %s for %s", |
There was a problem hiding this comment.
🤖 nit: the error message says "hudi writer major version" but HoodieVersion.get() returns the full version string (e.g. 0.14.0), not just the major. Could you drop "major" here? Also, could you swap "hudi" for "Hoodie" to stay consistent with the codebase convention?
- AI-generated; verify before applying. React 👍/👎 to flag quality.
Describe the issue this Pull Request addresses
Summary and Changelog
Changes included:
AWSGlueCatalogSyncClientImpact
Risk Level
low
Documentation Update
none
Contributor's checklist