fix(python): add proper typings for async method args and return types#2071
Merged
spetz merged 3 commits intoAug 3, 2025
Merged
Conversation
cstruct
commented
Aug 3, 2025
spetz
approved these changes
Aug 3, 2025
hubcio
approved these changes
Aug 3, 2025
hageshiame
pushed a commit
to hageshiame/iggy
that referenced
this pull request
Nov 7, 2025
apache#2071) Update [`pyo3-stub-gen`](https://github.com/Jij-Inc/pyo3-stub-gen) to `0.12.0` (with crates.io patch) to allowing us to override Python types in generated stub file. This fixes use of unsafe impls and provides types where we previously generated `typing.Any`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
pyo3-stub-gento0.12.0(with crates.io patch) to allowing us to override Python types in generated stub file. This fixes use of unsafe impls and provides types where we previously generatedtyping.Any.Once
0.12.0has been released to crates.io I will add another PR removing the patch but this should not block a release of the Python SDK since a built wheel does not care where we pull the sources from.