refactor(go): move command /foreign/go/internal/command#2881
Merged
numinnex merged 4 commits intoMar 9, 2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2881 +/- ##
============================================
- Coverage 68.48% 68.32% -0.17%
Complexity 739 739
============================================
Files 1053 1036 -17
Lines 84752 84240 -512
Branches 61286 60776 -510
============================================
- Hits 58046 57559 -487
+ Misses 24327 24324 -3
+ Partials 2379 2357 -22
🚀 New features to boost your workflow:
|
mmodzelewski
approved these changes
Mar 6, 2026
atharvalade
approved these changes
Mar 7, 2026
Contributor
atharvalade
left a comment
There was a problem hiding this comment.
I reviewed this and everything looks good to me.
spetz
approved these changes
Mar 9, 2026
numinnex
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow-up to #2737
Rationale
foreign/go/contractcurrently contains many different types, but they serve different purposes, such as data definition, and commands.This PR aims to separate command-related types from the
contractdirectory to improve maintainability and readability. In addition, this separation will make it easier to implement tests for command serialization methods.What changed?
Move command types to
/foreign/go/internal/commandLocal Execution
AI Usage
None