test: add UT for GlobalTransactionScanner class #7433
Merged
+915
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests for the GlobalTransactionScanner class by updating the changelog entries.
- Added changelog entries in the Chinese and English changelog files to note the new unit tests
- Ensured consistency in the changelog description for tracking test coverage updates
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| changes/zh-cn/2.x.md | Added test entry for GlobalTransactionScanner in Chinese |
| changes/en-us/2.x.md | Added test entry for GlobalTransactionScanner in English |
Comments suppressed due to low confidence (1)
changes/zh-cn/2.x.md:91
- [nitpick] Consider revising the changelog entry wording for GlobalTransactionScanner to match the style of similar entries. For example, change it to '为 GlobalTransactionScanner 类添加了单元测试'.
+- [[#7433](https://github.com/apache/incubator-seata/pull/7433)] 增加对 GlobalTransactionScanner 添加了测试
xingfudeshi
reviewed
Jun 12, 2025
spring/src/test/java/org/apache/seata/spring/annotation/GlobalTransactionScannerTest.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7433 +/- ##
============================================
+ Coverage 58.33% 59.46% +1.13%
+ Complexity 575 547 -28
============================================
Files 1269 1281 +12
Lines 45774 46186 +412
Branches 5555 5568 +13
============================================
+ Hits 26700 27463 +763
+ Misses 16510 16154 -356
- Partials 2564 2569 +5 see 68 files with indirect coverage changes 🚀 New features to boost your workflow:
|
funky-eyes
approved these changes
Jun 13, 2025
Contributor
funky-eyes
left a comment
There was a problem hiding this comment.
LGTM
Please send your DingTalk ID to jianbin@apache.org, and I will invite you to join the Seata developers group.
slievrly
pushed a commit
to slievrly/fescar
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Fixes: #7376
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews