GH-856: Fix using BC-FIPS #857
Merged
+263
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BC-FIPS is quite different from normal BC when it comes to ed25519 keys. FIPS 140-3 includes ed25519. (140-2 didn't.) Back-port generic ed25519 operations from the 3.0.0 milestone branch and use them to get raw key bytes, or to construct keys from raw bytes. This avoids the need to use BC-specific classes that differ between BC-FIPS and normal BC. Add a test run that executes a test using BC-FIPS instead of plain BC. The test exercises all kinds of public key types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BC-FIPS is quite different from normal BC when it comes to ed25519 keys. FIPS 140-3 includes ed25519. (140-2 didn't.)
Back-port generic ed25519 operations from the 3.0.0 milestone branch and use them to get raw key bytes, or to construct keys from raw bytes. This avoids the need to use BC-specific classes that differ between BC-FIPS and normal BC.
Add a test run that executes a test using BC-FIPS instead of plain BC. The test exercises all kinds of public key types.
Fixes #856.