Skip to content

[improve][test] validate redelivery delay for negative backoff #18264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 1 commit into from
Nov 1, 2022
Merged

[improve][test] validate redelivery delay for negative backoff #18264

Technoboy- merged 1 commit into from
Nov 1, 2022
+61 −53

Conversation

@codelipenghui
Copy link
Contributor

@codelipenghui codelipenghui commented Oct 31, 2022

Motivation

We have missed the redelivery delay validation in the tests. The PR tries to add total redelivery delay validation to make sure the negative backoff is working as expected.

Modifications

  • Add redelivery total delay validation
  • Clean up unused methods from MultiplierRedeliveryBackoff.java
  • Remove the unused ack timeout configuration for the test

@codelipenghui codelipenghui self-assigned this Oct 31, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Oct 31, 2022

@codelipenghui Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@codelipenghui codelipenghui added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/test doc-not-needed Your PR changes do not impact docs ready-to-test and removed doc-label-missing labels Oct 31, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Oct 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022 •
edited
Loading

Codecov Report

Merging #18264 (50f64e0) into master (6c65ca0) will increase coverage by 14.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18264       +/-   ##
=============================================
+ Coverage     34.91%   49.30%   +14.39%     
- Complexity     5707     6939     +1232     
=============================================
  Files           607      398      -209     
  Lines         53396    43588     -9808     
  Branches       5712     4475     -1237     
=============================================
+ Hits          18644    21492     +2848     
+ Misses        32119    19686    -12433     
+ Partials       2633     2410      -223
Flag Coverage Δ
unittests 49.30% <0.00%> (+14.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/PulsarBrokerStarter.java 0.00% <ø> (ø)
.../org/apache/pulsar/PulsarClusterMetadataSetup.java 0.00% <ø> (ø)
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 0.00% <ø> (ø)
...org/apache/pulsar/PulsarInitialNamespaceSetup.java 0.00% <ø> (ø)
.../main/java/org/apache/pulsar/PulsarStandalone.java 0.00% <0.00%> (ø)
...ava/org/apache/pulsar/PulsarStandaloneBuilder.java 0.00% <ø> (ø)
.../pulsar/broker/service/SharedConsumerAssignor.java 3.70% <0.00%> (-64.82%) ⬇️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) ⬇️
...apache/pulsar/broker/service/EntryAndMetadata.java 0.00% <0.00%> (-40.75%) ⬇️
...e/pulsar/broker/service/EntryBatchIndexesAcks.java 82.14% <0.00%> (-10.72%) ⬇️
... and 388 more

@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Oct 31, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Oct 31, 2022
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 1, 2022
@Technoboy- Technoboy- merged commit 2d75cbd into apache:master Nov 1, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Nov 1, 2022
@codelipenghui codelipenghui deleted the penghui/improve-test-unack branch November 1, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@liudezhi2098 liudezhi2098 Awaiting requested review from liudezhi2098

@congbobo184 congbobo184 Awaiting requested review from congbobo184

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

@codelipenghui codelipenghui

Labels

area/test doc-label-missing ready-to-test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@codelipenghui @codecov-commenter @Technoboy-