Skip to content

Conversation

@peter-toth
Copy link
Contributor

@peter-toth peter-toth commented Sep 26, 2025

What changes were proposed in this pull request?

This PR proposes to switch future Apache Spark 3.5 Java 11 docket images to 11-jammy.
We have applied a similar change to Apache Spark repo Java 17 dockerfile in SPARK-49005 / apache/spark#47488.

Why are the changes needed?

The current 11-jre-focal is no longer supported by Docker Library: docker-library/official-images#19948 (comment)

Does this PR introduce any user-facing change?

No, we will not republish the 3.5.7 Apache Docker Hub image.

How was this patch tested?

Manual review.

@peter-toth
Copy link
Contributor Author

cc @Yikun , @dongjoon-hyun

@peter-toth peter-toth changed the title Switch Spark 3.5 Java 11 docker registry images to 11-jammy [SPARK-53693] Switch Spark 3.5 Java 11 docker registry images to 11-jammy Sep 26, 2025
@peter-toth peter-toth changed the title [SPARK-53693] Switch Spark 3.5 Java 11 docker registry images to 11-jammy [SPARK-53730] Switch Spark 3.5 Java 11 docker registry images to 11-jammy Sep 26, 2025
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root cause of this problem is that we extended Spark 3.5.x as LTS.

From my side, it's a little weird that Docker Hub requires us to change our repo. Both images are independent basically, aren't they? Given that (1) exists without (2), I prefer to change (1) only because it's a breaking change to change underlying OSes.

  1. https://hub.docker.com/_/spark/tags
  2. https://hub.docker.com/r/apache/spark/

However, I know that you are making this PR as @Yikun 's recommendation. So, I wouldn't be against on this PR. Feel free to proceed this. I'm '0'.

@peter-toth
Copy link
Contributor Author

peter-toth commented Sep 30, 2025

From my side, it's a little weird that Docker Hub requires us to change our repo. Both images are independent basically, aren't they? Given that (1) exists without (2), I prefer to change (1) only because it's a breaking change to change underlying OSes.

  1. https://hub.docker.com/_/spark/tags
  2. https://hub.docker.com/r/apache/spark/

I'm ok with this proposal as well. We could add -jammy versions of https://github.com/apache/spark-docker/tree/master/3.5.7 to the repo and publish only those to docker library.

@peter-toth
Copy link
Contributor Author

@Yikun, @HyukjinKwon , I wonder if you have any idea how to publish 3.5.7 and future 3.5 releases to docker library?

@Yikun
Copy link
Member

Yikun commented Oct 3, 2025

I think we can:

For 3.5.7:

  1. Change the base image in codebase (3.5.7 and future release).

  2. apache image no need to publish again (which @dongjoon-hyun mentioned) I'm also OK.

  3. Publish Docker hub official image via submit PR.

For future release:

We can publish both two image from new code.

@peter-toth
Copy link
Contributor Author

Allright, thanks for the feedback @dongjoon-hyun and @Yikun.

In that case is there anything I need to change in this PR? Once this PR is merged I can update https://github.com/docker-library/official-images/pull/19948/files with the new commit hash. But we will not rerun Publish action for 3.5.7 here. Actually shall I increase the version in https://github.com/apache/spark-docker/blob/master/.github/workflows/publish.yml#L28-L31 now to prevent accidental 3.5.7 republish to Apache?

@Yikun
Copy link
Member

Yikun commented Oct 3, 2025

Publish image action is triggered by manually. so I think this PR is OK to go, and do doi refresh after PR merged.

And better to see is there any other comments from @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@peter-toth peter-toth closed this in 2ebf694 Oct 7, 2025
@peter-toth
Copy link
Contributor Author

Thanks for the review @dongjoon-hyun , @Yikun !

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants