-
Notifications
You must be signed in to change notification settings - Fork 52
[SPARK-53730] Switch Spark 3.5 Java 11 docker registry images to 11-jammy #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-53730] Switch Spark 3.5 Java 11 docker registry images to 11-jammy #95
Conversation
|
cc @Yikun , @dongjoon-hyun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause of this problem is that we extended Spark 3.5.x as LTS.
From my side, it's a little weird that Docker Hub requires us to change our repo. Both images are independent basically, aren't they? Given that (1) exists without (2), I prefer to change (1) only because it's a breaking change to change underlying OSes.
However, I know that you are making this PR as @Yikun 's recommendation. So, I wouldn't be against on this PR. Feel free to proceed this. I'm '0'.
I'm ok with this proposal as well. We could add |
|
@Yikun, @HyukjinKwon , I wonder if you have any idea how to publish 3.5.7 and future 3.5 releases to docker library? |
|
I think we can: For 3.5.7:
For future release: We can publish both two image from new code. |
|
Allright, thanks for the feedback @dongjoon-hyun and @Yikun. In that case is there anything I need to change in this PR? Once this PR is merged I can update https://github.com/docker-library/official-images/pull/19948/files with the new commit hash. But we will not rerun |
|
Publish image action is triggered by manually. so I think this PR is OK to go, and do doi refresh after PR merged. And better to see is there any other comments from @dongjoon-hyun |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
Thanks for the review @dongjoon-hyun , @Yikun ! Merged to |
What changes were proposed in this pull request?
This PR proposes to switch future Apache Spark 3.5 Java 11 docket images to
11-jammy.We have applied a similar change to Apache Spark repo Java 17 dockerfile in SPARK-49005 / apache/spark#47488.
Why are the changes needed?
The current
11-jre-focalis no longer supported by Docker Library: docker-library/official-images#19948 (comment)Does this PR introduce any user-facing change?
No, we will not republish the 3.5.7 Apache Docker Hub image.
How was this patch tested?
Manual review.