add: robots middleware#627
Merged
Merged
Conversation
|
|
tj
reviewed
Mar 28, 2018
| // New robots middleware. | ||
| func New(c *up.Config, next http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| if os.Getenv("UP_STAGE") != "production" { |
Member
There was a problem hiding this comment.
Works for me! Only thing I'd tweak for now is:
if os.Getenv("UP_STAGE") == "production" {
return next
}
return otherMiddlewareHere
Or we could delegate that decision to the handler.go so it's just never added for prod
Contributor
Author
There was a problem hiding this comment.
Yeah, that's much better. Incapsulated it in the middleware for now
Member
|
thanks man! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #610
Haven't add a way to turn it off. Should I? If so, in what format?