registry apply --yaml for artifacts #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 71.89% 71.91% +0.02%
==========================================
Files 146 146
Lines 12060 12097 +37
==========================================
+ Hits 8670 8700 +30
- Misses 2715 2721 +6
- Partials 675 676 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
timburks
reviewed
May 18, 2023
| kind: "FieldSetDefinition", | ||
| messageType: "google.cloud.apigeeregistry.v1.apihub.FieldSetDefinition", | ||
| mimeType: "application/octet-stream;type=google.cloud.apigeeregistry.v1.apihub.FieldSetDefinition", | ||
| }, |
There was a problem hiding this comment.
Were these just missing tests? (they are testing proto artifacts, right?)
There was a problem hiding this comment.
Yes, there were missing tests.
There was a problem hiding this comment.
Thanks, since these aren't related to the main PR, could you add a brief comment about that in the commit?
timburks
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses task #1 in #946