Skip to content

rewrite migrateArtifactsToRevisions to avoid dups #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2023
Merged

rewrite migrateArtifactsToRevisions to avoid dups #1193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4856d51
rewrite migrateArtifactsToRevisions to avoid dups
theganyo Jun 13, 2023
b311c71
Merge branch 'main' into theganyo/issue1192
theganyo Jun 13, 2023
02f5b7a
Merge branch 'main' into theganyo/issue1192
theganyo Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions server/registry/internal/storage/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,19 +209,25 @@ func (c *Client) ensureForeignKeys(ctx context.Context) (err error) {
}

func (c *Client) migrateArtifactsToRevisions(ctx context.Context) (err error) {
return c.db.Model(&models.Artifact{}).
Where("revision_id is null and spec_id != ''").
Update("revision_id",
c.db.Model(&models.Spec{}).Select("revision_id").
Where("artifacts.project_id = specs.project_id").
Where("artifacts.api_id = specs.api_id").
Where("artifacts.version_id = specs.version_id").
Where("artifacts.spec_id = specs.spec_id")).Joins(`join (?) latest
ON artifacts.project_id = latest.project_id
AND artifacts.api_id = latest.api_id
AND artifacts.version_id = latest.version_id
AND artifacts.spec_id = latest.spec_id
AND artifacts.revision_id = latest.revision_id`, c.latestSpecRevisionsQuery(ctx)).Error
return c.db.Exec(`
UPDATE artifacts
SET revision_id = specs.revision_id
FROM
-- ONLY LASTEST SPEC REVISIONS
(SELECT *
FROM
(SELECT *, row_number()
OVER
(partition by project_id,api_id,version_id,spec_id order by revision_create_time desc) as row
FROM specs)
AS rev
WHERE rev.row = 1) as specs
WHERE
artifacts.project_id = specs.project_id
AND artifacts.api_id = specs.api_id
AND artifacts.version_id = specs.version_id
AND artifacts.spec_id = specs.spec_id
`).Error
}

func (c *Client) DatabaseName(ctx context.Context) string {
Expand Down