Fix gzip validation for UpdateApiSpec #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform spec content updates after updating other fields on the spec to guarantee the MIME type check will use the current MIME type.
Codecov Report
@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 52.45% 52.53% +0.08%
==========================================
Files 71 71
Lines 6974 6974
==========================================
+ Hits 3658 3664 +6
+ Misses 2919 2915 -4
+ Partials 397 395 -2
Continue to review full report at Codecov.
|
timburks
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #626 by applying updates to spec contents only after updating every other field on the model. This guarantees the
mime_typeis up-to-date when we check whether to decompress the contents before recomputingsize_bytesandhash.See #626 (comment) for a full description of the bug and solution.