Skip to content

Remove check for specName while performing linting #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 31, 2022
Merged

Remove check for specName while performing linting #711

merged 3 commits into from
Aug 31, 2022

Conversation

@shrutiparabgoogle
Copy link
Contributor

Fixes #709

@codecov
Copy link

codecov bot commented Aug 31, 2022 •
edited
Loading

Codecov Report

Merging #711 (d6ecff9) into main (76088d4) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d6ecff9 differs from pull request most recent head 6cf4d34. Consider uploading reports for the commit 6cf4d34 to get more accurate results

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   55.60%   55.62%   +0.02%     
==========================================
  Files          93       93              
  Lines        7952     7949       -3     
==========================================
  Hits         4422     4422              
+ Misses       3065     3063       -2     
+ Partials      465      464       -1
Impacted Files Coverage Δ
...md/registry/plugins/registry-lint-spectral/main.go 53.38% <ø> (+1.32%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

giteshk added a commit to giteshk-org/registry that referenced this pull request Aug 31, 2022
@giteshk
apigee#711 ensure environment variables are scoped to the script
16fd943
@shrutiparabgoogle shrutiparabgoogle merged commit d172582 into apigee:main Aug 31, 2022
giteshk added a commit to giteshk-org/registry that referenced this pull request Sep 1, 2022
@giteshk
apigee#711 ensure environment variables are scoped to the script
6da01b8
giteshk added a commit to giteshk-org/registry that referenced this pull request Sep 1, 2022
@giteshk
apigee#711 ensure environment variables are scoped to the script
c861680
giteshk added a commit that referenced this pull request Sep 1, 2022
@giteshk
#711 ensure environment variables are scoped to the script (#716)
f641fbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelyara michaelyara Awaiting requested review from michaelyara

1 more reviewer

@timburks timburks timburks approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Apigee API Registry
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Registry Styleguide: evaluate specID condition in conformance calculation

2 participants

@shrutiparabgoogle @timburks