Skip to content

Conversation

@timburks
Copy link
Contributor

@timburks timburks commented Sep 1, 2022

addresses #717, follows the pattern in #698

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #718 (544c3c6) into main (952753d) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 544c3c6 differs from pull request most recent head c17fa81. Consider uploading reports for the commit c17fa81 to get more accurate results

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   56.93%   57.04%   +0.11%     
==========================================
  Files          93       93              
  Lines        8008     8008              
==========================================
+ Hits         4559     4568       +9     
+ Misses       3016     3009       -7     
+ Partials      433      431       -2     
Impacted Files Coverage Δ
server/registry/actions_deployments.go 76.33% <0.00%> (+1.77%) ⬆️
server/registry/actions_deployment_revisions.go 47.44% <0.00%> (+4.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timburks timburks changed the title prevent deletion of the last deployment revision prevent deletion of the only deployment revision Sep 1, 2022
@timburks timburks requested a review from theganyo September 1, 2022 18:23
@timburks timburks merged commit 68842b0 into apigee:main Sep 1, 2022
@timburks timburks deleted the protect-last-deployment-revision branch October 19, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants