Set limits on the number and lifetime of connections. #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #725 +/- ##
==========================================
+ Coverage 57.13% 57.21% +0.07%
==========================================
Files 93 93
Lines 8005 8005
==========================================
+ Hits 4574 4580 +6
+ Misses 3003 2999 -4
+ Partials 428 426 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
theganyo
approved these changes
Sep 6, 2022
| } | ||
| if err := applyConnectionLimits(db); err != nil { | ||
| c := &Client{db: db} | ||
| c.close() |
There was a problem hiding this comment.
FWIW, I find this to be a strange pattern we follow: Create a Client in order to call close() on it, which simply calls close() on the db we just constructed it on, only to then throw the client away.
There was a problem hiding this comment.
Good topic -- it looks like it's allowing us to keep the following code in one place:
sqlDB, _ := c.db.DB()
sqlDB.Close()
That could also be done with Client{db:db}.close()... or directly using the above code.
I don't have a strong preference. @seaneganx ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies fairly tight restrictions to database connection usage. When all connections are in use, the server blocks until one becomes available. This can cause operations to take longer when concurrency is high, but by not consuming all available connections, this keeps the database available for other clients. As noted in the comments, I think we may want to make this configurable.