Allow disable apollo client cache #4199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4199 +/- ##
============================================
+ Coverage 52.59% 52.62% +0.03%
- Complexity 2620 2627 +7
============================================
Files 484 484
Lines 15192 15200 +8
Branches 1571 1571
============================================
+ Hits 7990 7999 +9
- Misses 6645 6646 +1
+ Partials 557 555 -2
Continue to review full report at Codecov.
|
zouyx
reviewed
Jan 10, 2022
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Show resolved
Hide resolved
...t/src/test/java/com/ctrip/framework/apollo/spi/DefaultConfigFactoryDisableFileCacheTest.java
Outdated
Show resolved
Hide resolved
nobodyiam
reviewed
Jan 11, 2022
apollo-client/src/main/java/com/ctrip/framework/apollo/spi/DefaultConfigFactory.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-core/src/main/java/com/ctrip/framework/apollo/core/ApolloClientSystemConsts.java
Outdated
Show resolved
Hide resolved
e704fb5 to
8df1904
Compare
nobodyiam
reviewed
Jan 11, 2022
...t/src/test/java/com/ctrip/framework/apollo/spi/DefaultConfigFactoryDisableFileCacheTest.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/util/ConfigUtil.java
Show resolved
Hide resolved
Member
Author
|
@nobodyiam After this change, the default value is seted in private void initPropertyNamesCacheEnabled() {
propertyNamesCacheEnabled = getPropertyBoolean(ApolloClientSystemConsts.APOLLO_PROPERTY_NAMES_CACHE_ENABLE,
ApolloClientSystemConsts.APOLLO_PROPERTY_NAMES_CACHE_ENABLE_ENVIRONMENT_VARIABLES,
"false");
}If we keep the original, it might be confused for there are more than one code setting the init value. |
Member
Author
|
@nobodyiam PTAL again, thanks |
Anilople
reviewed
Jan 11, 2022
apollo-core/src/main/java/com/ctrip/framework/apollo/core/ApolloClientSystemConsts.java
Outdated
Show resolved
Hide resolved
cd483a2 to
24d10ac
Compare
24d10ac to
a23bca0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #4181
Brief changelog
apollo.property.file.cache.enableapollo.property.file.cache.enableis false, useRemoteConfigRepositoryFollow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.