Skip to content

Refine the description of the environment name #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nobodyiam merged 100 commits into from
Jan 25, 2024
Merged

Refine the description of the environment name #5082

nobodyiam merged 100 commits into from
Jan 25, 2024

Conversation

@klboke
Copy link
Contributor

@klboke klboke commented Jan 25, 2024

What's the purpose of this PR

This is an implicit logic within Apollo. If not described clearly, users will be very confused

  private static String getWellFormName(String envName) {
    if (StringUtils.isBlank(envName)) {
      return "";
    }

    String envWellFormName = envName.trim().toUpperCase();

    // special case for production in case of typo
    if ("PROD".equals(envWellFormName)) {
      return Env.PRO.name;
    }

    // special case that FAT & FWS should map to FAT
    if ("FWS".equals(envWellFormName)) {
      return Env.FAT.name;
    }

    return envWellFormName;
  }

klboke and others added 30 commits May 16, 2019 11:07
@klboke
add tech-support-qq-4.png
fe75b4d
@klboke
Update README.md
99bf97a
@klboke
Merge remote-tracking branch 'upstream/master'
1579f41 
# Conflicts:
#	README.md
@klboke
Merge remote-tracking branch 'upstream/master'
9f65eed
@klboke
Enhance the user experience in the scenario of submitting duplicate keys
d7d3fd9
@nobodyiam
Merge branch 'master' into master
7329fab
@klboke
Modify the key-value conflict exception prompt, adjust the code style
5def448
@nobodyiam
Merge branch 'master' into master
6942564
@klboke
Merge remote-tracking branch 'upstream/master'
0fc1f91
@klboke
Merge remote-tracking branch 'origin/master'
61ad016
@klboke
rge remote-tracking branch 'upstream/master'
587ce33
@klboke
Merge remote-tracking branch 'upstream/master'
9de6563
@klboke
Merge remote-tracking branch 'upstream/master'
9aab632
@klboke
Merge branch 'ctripcorp:master' into master
050dd0a
@klboke
Merge branch 'master' of github.com:klboke/apollo
5a64035
@klboke
Merge branch 'ctripcorp:master' into master
0648fbd
@klboke
Merge branch 'master' of github.com:klboke/apollo
35bd3a6
@klboke
Merge branch 'ctripcorp:master' into master
bc8149b
@klboke
Merge branch 'master' of github.com:klboke/apollo
e771bdd
@klboke
Merge branch 'ctripcorp:master' into master
9a1ad83
@klboke
Merge branch 'master' of github.com:klboke/apollo
3efef37
@klboke
Merge branch 'apolloconfig:master' into master
1274281
@klboke
Merge branch 'master' of github.com:klboke/apollo
a968932
@klboke
Merge branch 'apolloconfig:master' into master
df8942c
@klboke
Merge branch 'master' of github.com:klboke/apollo
f98175a
@klboke
Merge branch 'apolloconfig:master' into master
710cdd6
@klboke
Merge branch 'master' of github.com:klboke/apollo
3c162b6
@klboke
Merge branch 'apolloconfig:master' into master
0101a3f
@klboke
Merge branch 'master' of github.com:klboke/apollo
cc6f568
@klboke
Merge branch 'apolloconfig:master' into master
21dd30c
klboke and others added 20 commits March 20, 2023 19:21
@klboke
Merge branch 'master' of github.com:klboke/apollo
aa95cdd
@klboke
Merge branch 'apolloconfig:master' into master
3441587
@klboke
Merge branch 'master' of github.com:klboke/apollo
a09b174
@klboke
Merge branch 'apolloconfig:master' into master
8419fca
@klboke
Merge branch 'master' of github.com:klboke/apollo
d8d0664
@klboke
Merge branch 'apolloconfig:master' into master
0af7aa2
@klboke
Merge branch 'master' of github.com:klboke/apollo
b353db3
@klboke
Merge branch 'apolloconfig:master' into master
c31c388
@klboke
Merge branch 'master' of github.com:klboke/apollo
d652657
@klboke
Merge branch 'apolloconfig:master' into master
d0e1f94
@klboke
Merge branch 'master' of github.com:klboke/apollo
d95a534
@klboke
Merge branch 'apolloconfig:master' into master
c5cae91
@klboke
Merge branch 'master' of github.com:klboke/apollo
17714de
@klboke
Merge branch 'apolloconfig:master' into master
1dd9d18
@klboke
merge branch 'master' of github.com:klboke/apollo
1e228d3
@klboke
Merge branch 'apolloconfig:master' into master
7a43e83
@klboke
Merge branch 'master' of github.com:klboke/apollo
5c6954f
@klboke
Merge branch 'apolloconfig:master' into master
75d49c6
@klboke
e branch 'master' of github.com:klboke/apollo
b944f8a
@klboke
docs(portal): Refine the description of the environment name
3d75c96
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 25, 2024
@codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff44245) 49.59% compared to head (b2caaff) 49.60%.
Report is 1 commits behind head on master.

❗ Current head b2caaff differs from pull request most recent head c8e190e. Consider uploading reports for the commit c8e190e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5082   +/-   ##
=========================================
  Coverage     49.59%   49.60%           
- Complexity     1903     1904    +1     
=========================================
  Files           372      372           
  Lines         11564    11564           
  Branches       1127     1127           
=========================================
+ Hits           5735     5736    +1     
  Misses         5488     5488           
+ Partials        341      340    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nobodyiam
nobodyiam reviewed Jan 25, 2024
View reviewed changes
nobodyiam
nobodyiam approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2024
@nobodyiam nobodyiam merged commit 73b4b84 into apolloconfig:master Jan 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@klboke @nobodyiam