Skip to content

Conversation

@vermakhushboo
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 4, 2025

📝 Walkthrough

Walkthrough

The changes update how the hostname is determined in both the application configuration and related end-to-end tests. In the configuration file, the hostname is now retrieved exclusively from the _APP_DOMAIN environment variable, removing the previous fallback to _APP_CONSOLE_DOMAIN. Correspondingly, the test for template screenshot URLs in SitesCustomClientTest has been adjusted to dynamically use the value of _APP_DOMAIN when constructing expected URLs, rather than relying on a hardcoded localhost value. No changes were made to the declarations or signatures of exported or public entities.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbadfa7 and 2545977.

📒 Files selected for processing (2)
  • app/config/templates/site.php (1 hunks)
  • tests/e2e/Services/Sites/SitesCustomClientTest.php (3 hunks)
🔇 Additional comments (4)
app/config/templates/site.php (1)

10-10: No breaking change: _APP_DOMAIN is guaranteed in default deployments

Verified that the primary hostname variable (_APP_DOMAIN) is defined in docker-compose.yml and is already relied on by multiple runtime components (e.g. Executor.php). The site template in app/config/templates/site.php now consistently uses _APP_DOMAIN for its URLs, and removing the _APP_CONSOLE_DOMAIN fallback will not break existing setups under the standard configuration.

• docker-compose.yml declares _APP_DOMAIN alongside _APP_CONSOLE_DOMAIN
• Critical code paths (proxies, executors, certificate tasks) use _APP_DOMAIN directly
• Fallback to _APP_CONSOLE_DOMAIN remains in console-specific components

No further action needed.

tests/e2e/Services/Sites/SitesCustomClientTest.php (3)

9-9: Good addition of the required import.

The System class import is necessary for the environment variable retrieval added below.


125-125: Excellent alignment with configuration changes.

The hostname retrieval now matches the pattern used in app/config/templates/site.php, ensuring consistent behavior between the configuration and tests.


134-135: Perfect fix for the template test URLs.

The dynamic hostname construction now properly matches how URLs are generated in the site template configuration, replacing the hardcoded localhost with the actual configured domain. This addresses the "Fix site template test" objective mentioned in the PR title.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
pyc 3.12.9-r0 CVE-2024-12718 HIGH
pyc 3.12.9-r0 CVE-2025-4138 HIGH
pyc 3.12.9-r0 CVE-2025-4330 HIGH
pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3 3.12.9-r0 CVE-2024-12718 HIGH
python3 3.12.9-r0 CVE-2025-4138 HIGH
python3 3.12.9-r0 CVE-2025-4330 HIGH
python3 3.12.9-r0 CVE-2025-4517 HIGH
python3-pyc 3.12.9-r0 CVE-2024-12718 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4138 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4330 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2024-12718 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4138 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4330 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4517 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

✨ Benchmark results

  • Requests per second: 915
  • Requests with 200 status code: 164,750
  • P99 latency: 0.208936183

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 915 1,155
200 164,750 207,978
P99 0.208936183 0.164873651

@vermakhushboo vermakhushboo changed the title {WIP} Fix site template test Fix site template test Jul 4, 2025
@vermakhushboo vermakhushboo requested a review from Meldiron July 4, 2025 13:14
@Meldiron Meldiron merged commit 1cf9963 into 1.7.x Jul 4, 2025
38 checks passed
@stnguyen90 stnguyen90 deleted the chore-fix-site-template-test branch October 1, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants